[llvm] [MachineBasicBlock] Fix use after free in SplitCriticalEdge (PR #68786)

[Jay Foad via llvm-commits]

================
@@ -156,12 +156,14 @@ void ilist_traits<MachineInstr>::addNodeToList(MachineInstr *N) {
   MachineFunction *MF = Parent->getParent();
   N->addRegOperandsToUseLists(MF->getRegInfo());
   MF->handleInsertion(*N);
+  Parent->noteInsertion(*N);
----------------
jayfoad wrote:

Is there any measurable performance impact from this? You could push to a branch tracked by https://llvm-compile-time-tracker.com/ to check.

https://github.com/llvm/llvm-project/pull/68786