[PATCH] D141060: [opt] Infer DataLayout from triple if not specified

Tue Oct 10 18:04:52 PDT 2023

arichardson added a reviewer: AMDGPU.
arichardson added a comment.

In D141060#4653554 <https://reviews.llvm.org/D141060#4653554>, @MaskRay wrote:

> This is definitely the correct thing to do. Thanks for fixing this... You likely need to rebase. For courtesy to experimental targets, consider `-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD='ARC;AVR;CSKY;DirectX;LoongArch;M68k;SPIRV;Xtensa'` and fix possible failures from the experimental targets.

Thanks for reviewing!
I originally tested with `-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=all` and didn't see any new failures (SPIRV was broken already when I tested). Will test again tomorrow.

I will wait for @arsenm (or someone else from the amdgpu team) to check the amdgpu behaviour changes before committing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141060/new/

https://reviews.llvm.org/D141060