[llvm] 76f20e9 - [dsymutil] Rename DSYMUTIL_REPRODUCER_PATH to LLVM_DIAGNOSTIC_DIR

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 10:33:37 PDT 2023


Author: Jonas Devlieghere
Date: 2023-10-10T10:33:25-07:00
New Revision: 76f20e9cff222351505ec9dbb83fdb93e64ad691

URL: https://github.com/llvm/llvm-project/commit/76f20e9cff222351505ec9dbb83fdb93e64ad691
DIFF: https://github.com/llvm/llvm-project/commit/76f20e9cff222351505ec9dbb83fdb93e64ad691.diff

LOG: [dsymutil] Rename DSYMUTIL_REPRODUCER_PATH to LLVM_DIAGNOSTIC_DIR

Rename DSYMUTIL_REPRODUCER_PATH to LLVM_DIAGNOSTIC_DIR as the latter is
more generic and already set in our downstream build.

Added: 
    

Modified: 
    llvm/test/tools/dsymutil/X86/reproducer.test
    llvm/tools/dsymutil/Reproducer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/dsymutil/X86/reproducer.test b/llvm/test/tools/dsymutil/X86/reproducer.test
index 128cd5388011c2c..345bc38e6067499 100644
--- a/llvm/test/tools/dsymutil/X86/reproducer.test
+++ b/llvm/test/tools/dsymutil/X86/reproducer.test
@@ -21,7 +21,7 @@ RUN: env TMPDIR="%t/tempdir" dsymutil -o - -f %t/Inputs/basic.macho.x86_64
 RUN: not ls %t/tempdir/dsymutil-*
 
 # Create a reproducer.
-RUN: env DSYMUTIL_REPRODUCER_PATH=%t.repro dsymutil -gen-reproducer -f -o %t.generate -oso-prepend-path=%t %t/Inputs/basic.macho.x86_64 2>&1 | FileCheck %s --check-prefixes=REPRODUCER
+RUN: env LLVM_DIAGNOSTIC_DIR=%t.repro dsymutil -gen-reproducer -f -o %t.generate -oso-prepend-path=%t %t/Inputs/basic.macho.x86_64 2>&1 | FileCheck %s --check-prefixes=REPRODUCER
 RUN: llvm-dwarfdump -a %t.generate | FileCheck %s
 
 # Remove the input files and verify that was successful.

diff  --git a/llvm/tools/dsymutil/Reproducer.cpp b/llvm/tools/dsymutil/Reproducer.cpp
index 2522e2c09179143..99a23fc8003e31b 100644
--- a/llvm/tools/dsymutil/Reproducer.cpp
+++ b/llvm/tools/dsymutil/Reproducer.cpp
@@ -14,7 +14,7 @@ using namespace llvm::dsymutil;
 
 static std::string createReproducerDir(std::error_code &EC) {
   SmallString<128> Root;
-  if (const char *Path = getenv("DSYMUTIL_REPRODUCER_PATH")) {
+  if (const char *Path = getenv("LLVM_DIAGNOSTIC_DIR")) {
     Root.assign(Path);
     EC = sys::fs::create_directory(Root);
   } else {


        


More information about the llvm-commits mailing list