[PATCH] D155245: AArch64: don't crash when .cfi_startproc/.cfi_endproc are improperly nested

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 14:53:36 PDT 2023


jroelofs added a comment.

> - I suppose that there could be some weird code-gen that multiplexed the output between sections, so seeing a section switch before the closing cfi_endproc  is not sufficient

I tried this one and found it broke a lot of JIT tests, as well as some cases with inline asm.

> - if we encounter either a linker-visible or global symbol after a cfi_startproc but before the next cfi_endproc [in the same section], that would seem to indicate bad nesting?

I'll give this one a shot. I suspect it may also trip up on the same sorts of issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155245/new/

https://reviews.llvm.org/D155245



More information about the llvm-commits mailing list