[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #68131)

Alexander Yermolovich via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 14:50:06 PDT 2023


================
@@ -3514,11 +3520,15 @@ void DwarfDebug::addDwarfTypeUnitType(DwarfCompileUnit &CU,
       return;
     }
 
-    // If the type wasn't dependent on fission addresses, finish adding the type
-    // and all its dependent types.
     for (auto &TU : TypeUnitsToAdd) {
       InfoHolder.computeSizeAndOffsetsForUnit(TU.first.get());
       InfoHolder.emitUnit(TU.first.get(), useSplitDwarf());
+      if (getDwarfVersion() >= 5 &&
+          getAccelTableKind() == AccelTableKind::Dwarf) {
+        addTypeUnit(std::move(TU.first));
----------------
ayermolo wrote:

ran valgrind --tool=massif
https://valgrind.org/docs/manual/ms-manual.html#ms-manual.using-print
With Names:
![image](https://github.com/llvm/llvm-project/assets/43973793/c4f5debe-a0e3-4c47-9bf1-6b7c2b88b97f)
Without Names:
![image](https://github.com/llvm/llvm-project/assets/43973793/7f095780-5404-4b0e-b8b0-22d04464e02b)



https://github.com/llvm/llvm-project/pull/68131


More information about the llvm-commits mailing list