[llvm] [AST] Don't merge memory locations in AliasSetTracker (PR #65731)

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 13:15:57 PDT 2023


================
@@ -258,15 +258,15 @@ bool LoopVersioningLICM::legalLoopMemoryAccesses() {
     // With MustAlias its not worth adding runtime bound check.
     if (AS.isMustAlias())
       return false;
-    Value *SomePtr = AS.begin()->getValue();
+    const Value *SomePtr = AS.begin()->Ptr;
     bool TypeCheck = true;
     // Check for Mod & MayAlias
     HasMayAlias |= AS.isMayAlias();
     HasMod |= AS.isMod();
     for (const auto &A : AS) {
-      Value *Ptr = A.getValue();
+      const Value *Ptr = A.Ptr;
       // Alias tracker should have pointers of same data type.
-      TypeCheck = (TypeCheck && (SomePtr->getType() == Ptr->getType()));
+      TypeCheck = (TypeCheck && (SomePtr->getType() == Ptr->getType())); // FIXME: no longer effective check since opaque pointers?
----------------
jdoerfert wrote:

If anything, add the comment before the line.
Also, precommit since unrelated.

https://github.com/llvm/llvm-project/pull/65731


More information about the llvm-commits mailing list