[compiler-rt] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 11:38:31 PDT 2023


================
@@ -902,12 +890,16 @@ std::error_code SampleProfileReaderExtBinaryBase::readFuncProfiles() {
       for (const auto &NameOffset : FuncOffsetList) {
         const auto &FContext = NameOffset.first;
         auto FName = FContext.getName();
+        StringRef FNameString;
----------------
david-xl wrote:

auto FName = FContext.GetName() --> it is hard to tell the type of Fname by looking at it. Either using explicit type, or change the getter method name.

https://github.com/llvm/llvm-project/pull/66164


More information about the llvm-commits mailing list