[PATCH] D113424: ext-tsp basic block layout
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 9 08:10:50 PDT 2023
kosarev added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/CodeLayout.cpp:404-405
+ Result.insert(Result.end(), Begin1, End1);
+ Result.insert(Result.end(), Begin2, End2);
+ Result.insert(Result.end(), Begin3, End3);
+ return Result;
----------------
This seems to fail on expensive checks, see <https://github.com/llvm/llvm-project/issues/68594>.
Do `{Begin,End}{2,3}` really form valid ranges when default to `BlockIter()` in the constructor?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113424/new/
https://reviews.llvm.org/D113424
More information about the llvm-commits
mailing list