[llvm] [IPSCCP] Variable not visible at Og. (PR #66745)
Carlos Alberto Enciso via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 9 04:32:52 PDT 2023
================
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F,
}
}
-static bool runIPSCCP(
- Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM,
- std::function<const TargetLibraryInfo &(Function &)> GetTLI,
- std::function<TargetTransformInfo &(Function &)> GetTTI,
- std::function<AssumptionCache &(Function &)> GetAC,
- std::function<DominatorTree &(Function &)> GetDT,
- std::function<BlockFrequencyInfo &(Function &)> GetBFI,
- bool IsFuncSpecEnabled) {
+static void createDebugConstantExpression(Module &M, GlobalVariable *GV) {
+ SmallVector<DIGlobalVariableExpression *, 1> GVEs;
+ GV->getDebugInfo(GVEs);
+ if (GVEs.size() != 1)
+ return;
+
+ DIBuilder DIB(M);
+
+ // Create integer constant expression.
+ auto createIntegerExpression = [&DIB](const Constant *CV) -> DIExpression * {
+ const APInt &API = cast<ConstantInt>(CV)->getValue();
+ std::optional<uint64_t> InitIntOpt;
+ if (API.isNonNegative())
+ InitIntOpt = API.tryZExtValue();
+ else if (auto Temp = API.trySExtValue())
+ // Transform a signed optional to unsigned optional.
+ InitIntOpt = static_cast<uint64_t>(*Temp);
----------------
CarlosAlbertoEnciso wrote:
Good point. I think the original code would be better if we are dealing with `APSInt`. But for this case, we have `APInt`.
Changed to
```
std::optional<int64_t> InitIntOpt = API.trySExtValue();
return InitIntOpt ? DIB.createConstantValueExpression(
static_cast<uint64_t>(*InitIntOpt))
: nullptr;
```
https://github.com/llvm/llvm-project/pull/66745
More information about the llvm-commits
mailing list