[PATCH] D155431: [CMake] Clean up old code for handling MSVC runtime setting the old way

Sun Oct 1 14:57:38 PDT 2023

mstorsjo added a comment.

In D155431#4651692 <https://reviews.llvm.org/D155431#4651692>, @mstorsjo wrote:

> In D155431#4651689 <https://reviews.llvm.org/D155431#4651689>, @yurybura wrote:
>
>>> And I'm saying that it's redundant.
>>
>> Yes, it is. I'm just asking to save removing these flags for backward compatibility.
>
> Right.
>
> I'd be ok with restoring the removing of these flags temporarily (for a little while in git main, and backporting that to the 17.x release branch), but going forward, in an environment set up according to https://cmake.org/cmake/help/latest/policy/CMP0091.html, I think the user shouldn't be adding these flags manually.

I posted a PR for reinstating this flag removal in https://github.com/llvm/llvm-project/pull/67935.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155431/new/

https://reviews.llvm.org/D155431