[llvm] 8580010 - [ADT] Guard PagedVector death tests

Jakub Kuderski via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 30 12:47:19 PDT 2023


Author: Jakub Kuderski
Date: 2023-09-30T15:46:12-04:00
New Revision: 8580010672e9ff37b0744927296ca00dbcbef5be

URL: https://github.com/llvm/llvm-project/commit/8580010672e9ff37b0744927296ca00dbcbef5be
DIFF: https://github.com/llvm/llvm-project/commit/8580010672e9ff37b0744927296ca00dbcbef5be.diff

LOG: [ADT] Guard PagedVector death tests

These are not available in all build configurations.

Originally introuduced in: https://github.com/llvm/llvm-project/pull/66430

Added: 
    

Modified: 
    llvm/unittests/ADT/PagedVectorTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ADT/PagedVectorTest.cpp b/llvm/unittests/ADT/PagedVectorTest.cpp
index e1b0c62d3395747..55b69efe94ad927 100644
--- a/llvm/unittests/ADT/PagedVectorTest.cpp
+++ b/llvm/unittests/ADT/PagedVectorTest.cpp
@@ -24,8 +24,10 @@ TEST(PagedVectorTest, EmptyTest) {
   EXPECT_EQ(V.materialized_end().getIndex(), 0ULL);
   EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 0LL);
 
+#if GTEST_HAS_DEATH_TEST && !defined(NDEBUG)
   EXPECT_DEATH(V[0], "Index < Size");
   EXPECT_DEATH(PagedVector<int>(nullptr), "Allocator cannot be null");
+#endif
 }
 
 TEST(PagedVectorTest, ExpandTest) {
@@ -68,8 +70,11 @@ TEST(PagedVectorTest, HalfPageFillingTest) {
   EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 5LL);
   for (int I = 0; I < 5; ++I)
     EXPECT_EQ(V[I], I);
+
+#if GTEST_HAS_DEATH_TEST && !defined(NDEBUG)
   for (int I = 5; I < 10; ++I)
     EXPECT_DEATH(V[I], "Index < Size");
+#endif
 }
 
 TEST(PagedVectorTest, FillFullMultiPageTest) {
@@ -244,7 +249,10 @@ TEST(PagedVectorTest, ShrinkTest) {
   EXPECT_EQ(V.size(), 0ULL);
   EXPECT_EQ(V.capacity(), 0ULL);
   EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 0LL);
+
+#if GTEST_HAS_DEATH_TEST && !defined(NDEBUG)
   EXPECT_DEATH(V[0], "Index < Size");
+#endif
 }
 
 TEST(PagedVectorTest, FunctionalityTest) {


        


More information about the llvm-commits mailing list