[PATCH] D155431: [CMake] Clean up old code for handling MSVC runtime setting the old way

Thu Sep 28 05:32:28 PDT 2023

mstorsjo added a comment.

In D155431#4651646 <https://reviews.llvm.org/D155431#4651646>, @yurybura wrote:

> The main reason of the failure is  `/D_DEBUG`. CMake doesn't provide custom variables to handle this... In either case, this definition is checked in the source code and causes the build to fail.

That define should be set implicitly if `CMAKE_MSVC_RUNTIME_LIBRARY` is set to one of the debug choices, no?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155431/new/

https://reviews.llvm.org/D155431