[PATCH] D158716: [RFC][LV] VPlan-based cost model

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 03:48:34 PDT 2023


rengolin added a comment.

I agree with the general idea and the implementation seems reasonable, but I haven't worked in this part of the code for a long time, so would like folks like @fhahn and @Ayal to approve this one.

I'd like to see tests with the new flag. Perhaps reusing existing tests with a new RUN line and checking that the decisions are the same. After all, we don't want to change the behaviour with this patch, just the infrastructure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158716/new/

https://reviews.llvm.org/D158716



More information about the llvm-commits mailing list