[lld] [lld/ELF][test] Add test for .got too far away for R_X86_64_(REX_)GOTPCRELX (PR #67609)

[Arthur Eubanks via llvm-commits]

https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/67609

>From e14c782d54ceaf6a6b263412fb41c110da8e6d0f Mon Sep 17 00:00:00 2001
From: Arthur Eubanks <aeubanks at google.com>
Date: Wed, 27 Sep 2023 14:41:58 -0700
Subject: [PATCH 1/2] [lld/ELF][test] Add test for .got too far away for
 R_X86_64_(REX_)GOTPCRELX

---
 lld/test/ELF/x86-64-gotpc-no-relax-err.s | 25 ++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 lld/test/ELF/x86-64-gotpc-no-relax-err.s

diff --git a/lld/test/ELF/x86-64-gotpc-no-relax-err.s b/lld/test/ELF/x86-64-gotpc-no-relax-err.s
new file mode 100644
index 000000000000000..d5eac0f358decf8
--- /dev/null
+++ b/lld/test/ELF/x86-64-gotpc-no-relax-err.s
@@ -0,0 +1,25 @@
+# REQUIRES: x86
+# RUN: split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/a.s -o %t/a.o
+# RUN: not ld.lld --no-relax -T %t/lds %t/a.o -o /dev/null 2>&1 | FileCheck %s
+
+## Test diagnostics for unrelaxed GOTPCRELX overflows. In addition, test that there is no
+## `>>> defined in` for linker synthesized __stop_* symbols (there is no
+## associated file or linker script line number).
+
+# CHECK:      error: {{.*}}:(.text+0x2): relocation R_X86_64_GOTPCRELX out of range: 2147483658 is not in [-2147483648, 2147483647]; references '__stop_data'
+# CHECK-NEXT: error: {{.*}}:(.text+0x9): relocation R_X86_64_REX_GOTPCRELX out of range: 2147483651 is not in [-2147483648, 2147483647]; references '__stop_data'
+# CHECK-NOT: error:
+
+#--- a.s
+  movl __stop_data at GOTPCREL(%rip), %eax  # out of range
+  movq __stop_data at GOTPCREL(%rip), %rax  # out of range
+  movq __stop_data at GOTPCREL(%rip), %rax  # in range
+
+.section data,"aw", at progbits
+
+#--- lds
+SECTIONS {
+  .text 0x200000 : { *(.text) }
+  .got 0x80200010 : { *(.got) }
+}

>From a5f707961279964c1e8c30711d496335d005cd70 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks <aeubanks at google.com>
Date: Wed, 27 Sep 2023 14:51:18 -0700
Subject: [PATCH 2/2] --implicit-check-not

---
 lld/test/ELF/x86-64-gotpc-no-relax-err.s | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lld/test/ELF/x86-64-gotpc-no-relax-err.s b/lld/test/ELF/x86-64-gotpc-no-relax-err.s
index d5eac0f358decf8..84b0d304df4ac61 100644
--- a/lld/test/ELF/x86-64-gotpc-no-relax-err.s
+++ b/lld/test/ELF/x86-64-gotpc-no-relax-err.s
@@ -1,7 +1,7 @@
 # REQUIRES: x86
 # RUN: split-file %s %t
 # RUN: llvm-mc -filetype=obj -triple=x86_64 %t/a.s -o %t/a.o
-# RUN: not ld.lld --no-relax -T %t/lds %t/a.o -o /dev/null 2>&1 | FileCheck %s
+# RUN: not ld.lld --no-relax -T %t/lds %t/a.o -o /dev/null 2>&1 | FileCheck %s --implicit-check-not=error:
 
 ## Test diagnostics for unrelaxed GOTPCRELX overflows. In addition, test that there is no
 ## `>>> defined in` for linker synthesized __stop_* symbols (there is no
@@ -9,7 +9,6 @@
 
 # CHECK:      error: {{.*}}:(.text+0x2): relocation R_X86_64_GOTPCRELX out of range: 2147483658 is not in [-2147483648, 2147483647]; references '__stop_data'
 # CHECK-NEXT: error: {{.*}}:(.text+0x9): relocation R_X86_64_REX_GOTPCRELX out of range: 2147483651 is not in [-2147483648, 2147483647]; references '__stop_data'
-# CHECK-NOT: error:
 
 #--- a.s
   movl __stop_data at GOTPCREL(%rip), %eax  # out of range