[PATCH] D157020: [lld/ELF] Don't relax R_X86_64_(REX_)GOTPCRELX when offset is too far
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 27 14:36:09 PDT 2023
aeubanks added inline comments.
================
Comment at: lld/ELF/Arch/X86_64.cpp:331
+ continue;
+ if (rel.expr != R_RELAX_GOT_PC)
+ continue;
----------------
MaskRay wrote:
> If `R_RELAX_GOT_PC ` is tested, is R_X86_64_GOTPCRELX/R_X86_64_REX_GOTPCRELX check still necessary?
I was worried that other arches/relocations would use `R_RELAX_GOT_PC`, but no it's just R_X86_64_GOTPCRELX/R_X86_64_REX_GOTPCRELX, so removed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157020/new/
https://reviews.llvm.org/D157020
More information about the llvm-commits
mailing list