[PATCH] D137451: [CMake] Use LLVM_RUNTIME_TARGET in runtimes

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 12:11:20 PDT 2023


mstorsjo added a comment.

In D137451#4651362 <https://reviews.llvm.org/D137451#4651362>, @phosek wrote:

> This should be addressed in the latest version.

Ok, so this now retains `LLVM_DEFAULT_TARGET_TRIPLE` as the external user-settable cache variable that controls this, while the internal code is refactored to use `LLVM_RUNTIME_TARGET` instead? And I guess it's possible to build this by just setting `LLVM_RUNTIME_TARGET` directly too, even if that's not a cache variable?

That seems reasonable to me. Would the next steps after that be to do an actual deprecation cycle - warning users if they're setting the old variable name and making `LLVM_RUNTIME_TARGET` a cache variable as well? And then after the next release (or later?), remove handling of the old variable name here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137451/new/

https://reviews.llvm.org/D137451



More information about the llvm-commits mailing list