[polly] [TargetLowering] remove unused virtual from ComputeConstraintToUse (PR #67171)

[Nick Desaulniers via llvm-commits]

https://github.com/nickdesaulniers updated https://github.com/llvm/llvm-project/pull/67171

>From 6c3b4b15cd5ebd0de789863229eb2f61df455f00 Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers at google.com>
Date: Fri, 22 Sep 2023 09:36:58 -0700
Subject: [PATCH 1/3] [TargetLowering] remove unused virtual from
 ComputeConstraintToUse

There are no overrides in tree.

Fix up resulting linkage failures in unittests and sort the dependency
lists.
---
 llvm/include/llvm/CodeGen/TargetLowering.h   | 5 ++---
 llvm/unittests/Analysis/CMakeLists.txt       | 3 ++-
 llvm/unittests/Passes/Plugins/CMakeLists.txt | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/llvm/include/llvm/CodeGen/TargetLowering.h b/llvm/include/llvm/CodeGen/TargetLowering.h
index b2a0a8c15cf14de..3085e58ae87b282 100644
--- a/llvm/include/llvm/CodeGen/TargetLowering.h
+++ b/llvm/include/llvm/CodeGen/TargetLowering.h
@@ -4842,9 +4842,8 @@ class TargetLowering : public TargetLoweringBase {
   /// AsmOperandInfo, setting OpInfo.ConstraintCode and OpInfo.ConstraintType.
   /// If the actual operand being passed in is available, it can be passed in as
   /// Op, otherwise an empty SDValue can be passed.
-  virtual void ComputeConstraintToUse(AsmOperandInfo &OpInfo,
-                                      SDValue Op,
-                                      SelectionDAG *DAG = nullptr) const;
+  void ComputeConstraintToUse(AsmOperandInfo &OpInfo, SDValue Op,
+                              SelectionDAG *DAG = nullptr) const;
 
   /// Given a constraint, return the type of constraint it is for this target.
   virtual ConstraintType getConstraintType(StringRef Constraint) const;
diff --git a/llvm/unittests/Analysis/CMakeLists.txt b/llvm/unittests/Analysis/CMakeLists.txt
index 847430bf17697ab..6e5bb703dacf188 100644
--- a/llvm/unittests/Analysis/CMakeLists.txt
+++ b/llvm/unittests/Analysis/CMakeLists.txt
@@ -2,11 +2,12 @@ set(LLVM_LINK_COMPONENTS
   Analysis
   AsmParser
   Core
+  IPO
   Passes
+  SelectionDAG
   Support
   TargetParser
   TransformUtils
-  IPO
   )
 
 set(ANALYSIS_TEST_SOURCES
diff --git a/llvm/unittests/Passes/Plugins/CMakeLists.txt b/llvm/unittests/Passes/Plugins/CMakeLists.txt
index e90cae167bc2223..986ce1a55bf4f5d 100644
--- a/llvm/unittests/Passes/Plugins/CMakeLists.txt
+++ b/llvm/unittests/Passes/Plugins/CMakeLists.txt
@@ -3,7 +3,7 @@
 # work with DLLs on Windows (where a shared library can't have undefined
 # references), so just skip this testcase on Windows.
 if (NOT WIN32 AND NOT CYGWIN)
-  set(LLVM_LINK_COMPONENTS Support Passes Core AsmParser)
+  set(LLVM_LINK_COMPONENTS Support Passes Core AsmParser SelectionDAG)
   add_llvm_unittest(PluginsTests
     PluginsTest.cpp
     )

>From ca6096071561026ef9e1c4331077a327e1e7e48e Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers at google.com>
Date: Mon, 25 Sep 2023 09:02:29 -0700
Subject: [PATCH 2/3] fix up llvm-extract

---
 llvm/tools/llvm-extract/CMakeLists.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/llvm/tools/llvm-extract/CMakeLists.txt b/llvm/tools/llvm-extract/CMakeLists.txt
index 4521b5eeaff4aa7..19570854113a331 100644
--- a/llvm/tools/llvm-extract/CMakeLists.txt
+++ b/llvm/tools/llvm-extract/CMakeLists.txt
@@ -3,9 +3,10 @@ set(LLVM_LINK_COMPONENTS
   BitWriter
   Core
   IPO
-  IRReader
   IRPrinter
+  IRReader
   Passes
+  SelectionDAG
   Support
   )
 

>From ebe19132048f9e69e7e42cd11eb5645316688867 Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers at google.com>
Date: Wed, 27 Sep 2023 08:38:35 -0700
Subject: [PATCH 3/3] fix Polly unittests unresolved symbols errors on Windows

---
 polly/unittests/DeLICM/CMakeLists.txt            | 1 +
 polly/unittests/ScheduleOptimizer/CMakeLists.txt | 3 +++
 polly/unittests/ScopPassManager/CMakeLists.txt   | 3 +++
 3 files changed, 7 insertions(+)

diff --git a/polly/unittests/DeLICM/CMakeLists.txt b/polly/unittests/DeLICM/CMakeLists.txt
index e3e3062f4e8186f..f3d47d4cdfee34e 100644
--- a/polly/unittests/DeLICM/CMakeLists.txt
+++ b/polly/unittests/DeLICM/CMakeLists.txt
@@ -1,6 +1,7 @@
 # Solaris ld requires this dependency to be made explicit for shared builds.
 set(LLVM_LINK_COMPONENTS
   Core
+  SelectionDAG
   )
 
 add_polly_unittest(DeLICMTests
diff --git a/polly/unittests/ScheduleOptimizer/CMakeLists.txt b/polly/unittests/ScheduleOptimizer/CMakeLists.txt
index 2b4736027aab0fd..20042b5cab334db 100644
--- a/polly/unittests/ScheduleOptimizer/CMakeLists.txt
+++ b/polly/unittests/ScheduleOptimizer/CMakeLists.txt
@@ -1,3 +1,6 @@
+set(LLVM_LINK_COMPONENTS
+  SelectionDAG
+  )
 add_polly_unittest(ScheduleOptimizerTests
     ScheduleTreeTransformTest.cpp
   )
diff --git a/polly/unittests/ScopPassManager/CMakeLists.txt b/polly/unittests/ScopPassManager/CMakeLists.txt
index 88300144af352e4..91b1f5f83872e3e 100644
--- a/polly/unittests/ScopPassManager/CMakeLists.txt
+++ b/polly/unittests/ScopPassManager/CMakeLists.txt
@@ -1,3 +1,6 @@
+set(LLVM_LINK_COMPONENTS
+  SelectionDAG
+  )
 add_polly_unittest(ScopPassManagerTests
   PassManagerTest.cpp
   )