[llvm] eff4ef2 - Revert "[AArch64] Enable "sink-and-fold" in MachineSink by default (#67432)"

Momchil Velikov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 06:27:08 PDT 2023


Author: Momchil Velikov
Date: 2023-09-27T14:24:59+01:00
New Revision: eff4ef25b3dcc6f6506d9ba448a1216cab7c7fe8

URL: https://github.com/llvm/llvm-project/commit/eff4ef25b3dcc6f6506d9ba448a1216cab7c7fe8
DIFF: https://github.com/llvm/llvm-project/commit/eff4ef25b3dcc6f6506d9ba448a1216cab7c7fe8.diff

LOG: Revert "[AArch64] Enable "sink-and-fold" in MachineSink by default (#67432)"

This reverts commit ace20e24287bf531bb1185e213642c3b49eb293c.

This might be causing a buildbot failure at
https://green.lab.llvm.org/green/job/clang-stage1-RA/35786/

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
    llvm/test/CodeGen/AArch64/sink-and-fold.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp b/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
index fcc30a7cfceaf47..3d818c76bd4b7d7 100644
--- a/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
+++ b/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
@@ -200,7 +200,7 @@ static cl::opt<bool> EnableGISelLoadStoreOptPostLegal(
 static cl::opt<bool>
     EnableSinkFold("aarch64-enable-sink-fold",
                    cl::desc("Enable sinking and folding of instruction copies"),
-                   cl::init(true), cl::Hidden);
+                   cl::init(false), cl::Hidden);
 
 extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeAArch64Target() {
   // Register the target.

diff  --git a/llvm/test/CodeGen/AArch64/sink-and-fold.ll b/llvm/test/CodeGen/AArch64/sink-and-fold.ll
index 52007221e12a7b5..632fdb391053121 100644
--- a/llvm/test/CodeGen/AArch64/sink-and-fold.ll
+++ b/llvm/test/CodeGen/AArch64/sink-and-fold.ll
@@ -1,5 +1,5 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc < %s | FileCheck %s
+; RUN: llc -aarch64-enable-sink-fold=true < %s | FileCheck %s
 target triple = "aarch64-linux"
 
 declare i32 @use(...)


        


More information about the llvm-commits mailing list