[llvm] [AArch64] Stack probing for dynamic allocas in GlobalISel (PR #67123)

Momchil Velikov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 02:02:52 PDT 2023


momchil-velikov wrote:

> This looks like too many changes for a single PR.

Yeah, it's too many, I have separate PRs for:
* https://github.com/llvm/llvm-project/pull/66524 (Stack probing in prologues)
* https://github.com/llvm/llvm-project/pull/66525 (Stack probing for dynamic allocation in SelectionDSG)
* this one (Stack probing for dynamic allocation in GlobalISel)
* maybe others

In the Phabricator days those would be dependent reviews, here they are just three branches on top of each other,
with each commit visible.

Perhaps I should mark the head of each PR in the commit message, so the structure is evident and people can start review from the first one, while still seeing the big picture.

https://github.com/llvm/llvm-project/pull/67123


More information about the llvm-commits mailing list