[llvm] [NFC] refactor demangle of llvm-nm (PR #67481)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 23:55:42 PDT 2023


================
@@ -822,15 +798,8 @@ static void printSymbolList(SymbolicFile &Obj,
 
     std::string Name = S.Name;
     MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(&Obj);
-    if (Demangle) {
-      function_ref<std::optional<std::string>(StringRef)> Fn = ::demangle;
-      if (Obj.isXCOFF())
-        Fn = demangleXCOFF;
-      if (Obj.isMachO())
-        Fn = demangleMachO;
-      if (std::optional<std::string> Opt = Fn(S.Name))
-        Name = *Opt;
-    }
+    if (Demangle)
+      Name = llvm::demangle(Name);
----------------
jh7370 wrote:

I don't think you need the `llvm::` prefix?

https://github.com/llvm/llvm-project/pull/67481


More information about the llvm-commits mailing list