[llvm] [WebAssembly] Allow absolute symbols in the linking section (symbol table) (PR #67493)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 14:55:05 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 2ff45f04a6d32b20558f07d1017e861b48317592 ea09121324b22cf1897da33324209159f9c39826 -- lld/wasm/SymbolTable.cpp lld/wasm/SyntheticSections.cpp llvm/include/llvm/BinaryFormat/Wasm.h llvm/lib/Object/WasmObjectFile.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Object/WasmObjectFile.cpp b/llvm/lib/Object/WasmObjectFile.cpp
index 50ef4d2648ec..701e1294e500 100644
--- a/llvm/lib/Object/WasmObjectFile.cpp
+++ b/llvm/lib/Object/WasmObjectFile.cpp
@@ -733,8 +733,9 @@ Error WasmObjectFile::parseLinkingSectionSymtab(ReadContext &Ctx) {
           size_t SegmentSize = DataSegments[Index].Data.Content.size();
           if (Offset > SegmentSize)
             return make_error<GenericBinaryError>(
-                "invalid data symbol offset: `" + Info.Name + "` (offset: " +
-                    Twine(Offset) + " segment size: " + Twine(SegmentSize) + ")",
+                "invalid data symbol offset: `" + Info.Name +
+                    "` (offset: " + Twine(Offset) +
+                    " segment size: " + Twine(SegmentSize) + ")",
                 object_error::parse_failed);
         }
         Info.DataRef = wasm::WasmDataReference{Index, Offset, Size};

``````````

</details>


https://github.com/llvm/llvm-project/pull/67493


More information about the llvm-commits mailing list