[PATCH] D158124: [dsymutil] Add support for mergeable libraries

[Alpha Abdoulaye via Phabricator via llvm-commits]

Alpha marked 4 inline comments as done.
Alpha added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1787
+                       AttrInfo, IsLittleEndian);
+    if (FinalAttrSize != 0) {
+      AttributesFixups.push_back(CurAttrFixup);
----------------
avl wrote:
> it would be good to add check for ObjFile.Addresses->getLibraryInstallName() here to not collect AttributeLinkedOffsetFixup if not necessary:
> 
> 
> ```
> std::optional<StringRef> LibraryInstallName = ObjFile.Addresses->getLibraryInstallName();
> .....
> if (FinalAttrSize != 0 && LibraryInstallName.has_value()) {
> ```
Hmm, we also need t have the fixups/relocs saved, even if we're dealing with regular object files, as we still need to always save the relocations, regardless of the type of input file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158124/new/

https://reviews.llvm.org/D158124