[compiler-rt] [sanitizer] Don't ignore Symbolizer errors (PR #67466)
Thurston Dang via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 26 12:39:12 PDT 2023
================
@@ -77,13 +77,16 @@ bool __sanitizer_symbolize_code(const char *ModuleName, uint64_t ModuleOffset,
auto ResOrErr = getDefaultSymbolizer()->symbolizeInlinedCode(
ModuleName,
{ModuleOffset, llvm::object::SectionedAddress::UndefSection});
- Printer->print(Request,
- ResOrErr ? ResOrErr.get() : llvm::DIInliningInfo());
+ Printer->print(Request, ResOrErr.get());
----------------
thurstond wrote:
Is there a reason for the differing behavior between here and lines 89/113? Here, it will unconditionally print the value of ResOrErr.get(), while in lines 89/113, it is only printed if successful.
https://github.com/llvm/llvm-project/pull/67466
More information about the llvm-commits
mailing list