[compiler-rt] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)
Bill Wendling via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 26 11:49:58 PDT 2023
================
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo {
outliner::Candidate &C) const override;
void buildClearRegister(Register Reg, MachineBasicBlock &MBB,
- MachineBasicBlock::iterator Iter,
- DebugLoc &DL) const override;
+ MachineBasicBlock::iterator Iter, DebugLoc &DL,
+ bool NoSideEffects = false) const override;
----------------
bwendling wrote:
I'm going to be using this for clearing registers using stack protectors. I don't think it's clearer to use `SideEffects`. I know it's a double negative, but it just feels more natural to me to say "I want the instruction to have no side effects."
https://github.com/llvm/llvm-project/pull/67193
More information about the llvm-commits
mailing list