[llvm] [llvm-profdata] Use simple enum for error checking in Sample Profile Reader (PR #67453)

[William Junda Huang via llvm-commits]

================
@@ -604,48 +604,52 @@ class SampleProfileReaderBinary : public SampleProfileReader {
   /// EC is set.
   ///
   /// \returns the read value.
-  template <typename T> ErrorOr<T> readNumber();
+  template <typename T> sampleprof_error readNumber(T &Result);
----------------
huangjd wrote:

I will do some more benchmarking to see the impact 

https://github.com/llvm/llvm-project/pull/67453