[llvm] [TableGen][RISCV][GlobalISel] Select G_ICMP, G_SELECT, G_PTR_ADD (PR #67185)

Michael Maitland via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 09:30:00 PDT 2023


================
@@ -198,13 +216,21 @@ bool RISCVInstructionSelector::select(MachineInstr &MI) {
 
   switch (Opc) {
   case TargetOpcode::G_ANYEXT:
-  case TargetOpcode::G_TRUNC:
+  case TargetOpcode::G_PTRTOINT:
+  case TargetOpcode::G_TRUNC: {
     MI.setDesc(TII.get(TargetOpcode::COPY));
+    bool selected = selectCopy(MI, MRI);
----------------
michaelmaitland wrote:

`selected` -> `Selected` ("Variable names should be nouns (as they represent state). The name should be camel case, and start with an upper case letter (e.g. Leader or Boats).")

https://github.com/llvm/llvm-project/pull/67185


More information about the llvm-commits mailing list