[llvm] [Inliner] Fix bug when propagating poison generating return attributes (PR #66036)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 08:51:58 PDT 2023


goldsteinn wrote:

> > > I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One is trivial, one is probably easy, and then one with the new stuff.
> > 
> > 
> > So PR based on PR? The thing is there are dependencies between commits. My expectation is that I will push commits as they are approved, not the whole PR at once.
> 
> We always had dependences between commits. Just mention it in the commit message. This PR contains arguably different things. It simply makes it harder to review it. The guidance on this is clear, make review chunks as small if possible. The RFC commits, the fix, and the new functionality do not need to be commingled.

Okay, I can't really see a reasonable way to create a proper series. I am going to submit this piece-meal.
At the moment only up to the bugfix submitted.
Do you by chance know a reasonable way to create a series of PRs s.t the individual commits can be
reasonably reviewed while also keeping all the commits together?
I look at SO answers like: https://stackoverflow.com/questions/30768148/git-split-pull-request-into-smaller-prs-based-upon-the-new-directories-in-the
but they only seem to work if the changes to to distinct files.

https://github.com/llvm/llvm-project/pull/66036


More information about the llvm-commits mailing list