[PATCH] D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name.

Tue Sep 26 07:04:23 PDT 2023

DiggerLin marked an inline comment as done.
DiggerLin added inline comments.

================
Comment at: llvm/test/tools/llvm-cxxfilt/delimiters.test:35
 COM: around this. See D111072.
-RUN:      '_Z3Foo$ ._Z3Foo' > %t
+RUN:      '_Z3Foo$ Foo._Z3Bar' > %t
 RUN:      llvm-cxxfilt -n < %t | FileCheck %s
----------------
jhenderson wrote:
> As per my previous comments, I think I'd prefer this to be `_Z3Foo._Z3Bar`, in keeping with the existing patterns above, which should then be identical in the output (i.e. `_Z3Foo._Z3Bar`).
without the patch or with the patch llvm-cxxfilt has the same behavior as 

```
bash> llvm-cxxfilt _Z3Foo._Z3Bar
 Foo (._Z3Bar)

```
so I do not use the `_Z3Foo._Z3Bar` as your suggestion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139864/new/

https://reviews.llvm.org/D139864