[PATCH] D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name.

Mon Sep 25 23:37:14 PDT 2023

jhenderson accepted this revision.
jhenderson added a subscriber: shchenz.
jhenderson added a comment.
This revision is now accepted and ready to land.

One remaining comment, then looks good to me

For reference, somebody else (possibly @shchenz?) put up https://github.com/llvm/llvm-project/pull/67389. They appear to be working on xcoff too, so it may be worth liaising with them/getting them involved with other reviews too.

================
Comment at: llvm/test/tools/llvm-cxxfilt/delimiters.test:35
 COM: around this. See D111072.
-RUN:      '_Z3Foo$ ._Z3Foo' > %t
+RUN:      '_Z3Foo$ Foo._Z3Bar' > %t
 RUN:      llvm-cxxfilt -n < %t | FileCheck %s
----------------
As per my previous comments, I think I'd prefer this to be `_Z3Foo._Z3Bar`, in keeping with the existing patterns above, which should then be identical in the output (i.e. `_Z3Foo._Z3Bar`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139864/new/

https://reviews.llvm.org/D139864