[llvm] [X86]Add NO_REVERSE attribute to X86 RMW instrs in memfold table (PR #67288)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 25 19:42:08 PDT 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 7ce800ba3197c6df866565b9be5709c8c2d64fc4 4f605318d7f583cd66136432f9ae4d111fbbe762 -- llvm/utils/TableGen/X86FoldTablesEmitter.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/utils/TableGen/X86FoldTablesEmitter.cpp b/llvm/utils/TableGen/X86FoldTablesEmitter.cpp
index cae75a7336e5..6cb6055286ce 100644
--- a/llvm/utils/TableGen/X86FoldTablesEmitter.cpp
+++ b/llvm/utils/TableGen/X86FoldTablesEmitter.cpp
@@ -402,10 +402,10 @@ void X86FoldTablesEmitter::addEntryWithFlags(FoldTable &Table,
Result.FoldLoad = S & TB_FOLDED_LOAD;
Result.FoldStore = S & TB_FOLDED_STORE;
Result.Alignment = Align(1ULL << ((S & TB_ALIGN_MASK) >> TB_ALIGN_SHIFT));
- if (isManual) {
+ if (isManual) {
Table[RegInstr] = Result;
return;
- }
+ }
// Only table0 entries should explicitly specify a load or store flag.
if (&Table == &Table0) {
@@ -433,7 +433,7 @@ void X86FoldTablesEmitter::addEntryWithFlags(FoldTable &Table,
// the unfolded load size will be based on the register size. If that’s bigger
// than the memory operand size, the unfolded load will load more memory and
// potentially cause a memory fault.
-if (getRegOperandSize(RegOpRec) > getMemOperandSize(MemOpRec))
+ if (getRegOperandSize(RegOpRec) > getMemOperandSize(MemOpRec))
Result.NoReverse = true;
// Check no-kz version's isMoveReg
``````````
</details>
https://github.com/llvm/llvm-project/pull/67288
More information about the llvm-commits
mailing list