[PATCH] D152730: [ConstraintElim] Add A < B if A is an increasing phi for A != B.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 557327.
fhahn marked 5 inline comments as done.
fhahn added a comment.

Addressed latest comments, thanks!

In D152730#4650563 <https://reviews.llvm.org/D152730#4650563>, @nikic wrote:

> Btw, I don't think that there is any useful SCEV sharing going on at the current pipeline position (did you see worse compile-time results prior to the phase ordering change?) I believe LPM1 does not use SCEV, only preserve it.

Yep, the pipeline adjustment only shaved off a small amout of compile-time (maybe ~0.05% or something IIRC), but should be worthwhile on its own.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152730/new/

https://reviews.llvm.org/D152730

Files:
  llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-lto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll
  llvm/test/Transforms/ConstraintElimination/analysis-invalidation.ll
  llvm/test/Transforms/ConstraintElimination/loops-header-tested-pointer-cmps.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-int-phis-wrapping.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-int-phis.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-pointer-phis-constant-upper-offset.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-pointer-phis-custom-datalayout.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-pointer-phis-early-exits.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-pointer-phis-struct-types.ll
  llvm/test/Transforms/ConstraintElimination/monotonic-pointer-phis.ll
  llvm/test/Transforms/PhaseOrdering/loop-access-checks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152730.557327.patch
Type: text/x-patch
Size: 63676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230925/b61cb7fe/attachment.bin>