[PATCH] D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 13:40:49 PDT 2023


DiggerLin added a comment.

In D139864#4650667 <https://reviews.llvm.org/D139864#4650667>, @MaskRay wrote:

> Thanks for the update. Doing the following looks good to me.
>
>   bool CanHaveLeadingDot = true;
>   if (StripUnderscore)
>     if (DecoratedStr[0].consume_front("_")) // simplified
>       CanHaveLeadingDot = false;
>   
>   std::string Result;
>   if (nonMicrosoftDemangle(DecoratedStr, Result, CanHaveLeadingDot))

DecoratedStr is object of class std::string_view, it do not have API consume_front  https://en.cppreference.com/w/cpp/string/basic_string_view


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139864/new/

https://reviews.llvm.org/D139864



More information about the llvm-commits mailing list