[PATCH] D136678: [AArch64][SVE2] Add the SVE2.1 pext and ptrue predicate-as-counter instructions

Mon Sep 25 05:59:30 PDT 2023

MattDevereau added inline comments.

================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp:540
+uint32_t
+AArch64MCCodeEmitter::EncodePPR_p8to15(const MCInst &MI, unsigned OpIdx,
+                                       SmallVectorImpl<MCFixup> &Fixups,
----------------
uabelho wrote:
> This method seems to be unused on trunk. gcc warns 
> ```
> ../lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp:550:1: warning: 'uint32_t {anonymous}::AArch64MCCodeEmitter::EncodePPR_p8to15(const llvm::MCInst&, unsigned int, llvm::SmallVectorImpl<llvm::MCFixup>&, const llvm::MCSubtargetInfo&) const' defined but not used [-Wunused-function]
> ```
> Will it be used or should it perhaps be removed?
Hello, thanks for reporting this. This was unused due to a patch I pushed recently at https://github.com/llvm/llvm-project/pull/65306. I've pushed another patch to remove this function: https://reviews.llvm.org/rG69ba4aed004d

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136678/new/

https://reviews.llvm.org/D136678