[PATCH] D159073: [PowerPC][Peephole] Combine rldicl/rldicr and andi/andis after isel.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 02:39:40 PDT 2023


shchenz added a comment.

LGTM with one nit.

Thanks for improving this.



================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1120
+        // if all bits to AND are already zero in the input.
+        bool Pattern1 =
+            (SrcOpCode == PPC::RLDICL && (RZeroAndImm + ImmSrc > 63)) ||
----------------
nit: PatternResultZero & PatternRemoveRotate for `Pattern1` and `Pattern2`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159073/new/

https://reviews.llvm.org/D159073



More information about the llvm-commits mailing list