[PATCH] D154205: [MachineLICM] Handle subloops

JinGu Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 00:40:36 PDT 2023


jaykang10 updated this revision to Diff 557289.
jaykang10 added a comment.

Fixed a bug.

- `ExtractHoistableLoad` can erase MI. It creates new MI for unfolding load and assigns it to MI but the MI is not updated with new MI because it is passed as reference parameter. In this case, the MI is not valid.
- `ExtractHoistableLoad` updates the register pressure for the new MI so we do not need to update the register pressure for it outside the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154205/new/

https://reviews.llvm.org/D154205

Files:
  llvm/lib/CodeGen/MachineLICM.cpp
  llvm/test/CodeGen/AArch64/machine-licm-sub-loop.ll
  llvm/test/CodeGen/AMDGPU/agpr-copy-no-free-registers.ll
  llvm/test/CodeGen/AMDGPU/exec-mask-opt-cannot-create-empty-or-backward-segment.ll
  llvm/test/CodeGen/AMDGPU/optimize-negated-cond.ll
  llvm/test/CodeGen/AMDGPU/tuple-allocation-failure.ll
  llvm/test/CodeGen/Thumb2/mve-gather-scatter-optimisation.ll
  llvm/test/CodeGen/WebAssembly/reg-stackify.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154205.557289.patch
Type: text/x-patch
Size: 58372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230925/9510965a/attachment.bin>


More information about the llvm-commits mailing list