[PATCH] D149757: Test data for symbol lookup. NFC
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 17 23:49:07 PDT 2023
jhenderson added a comment.
Strong +1 to what both @ikudrin and @dblaikie have said: these files on their own don't do anything useful (not even add a test), so they shouldn't be added on their own in a separate commit/review. Please merge them into the review that uses them, or create the test that uses them, but showing the old behaviour instead (I think the former is my preference in this context).
I think I have concerns about these files in their current state anyway, but I'd like to avoid commenting on them until they are in the "right" patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149757/new/
https://reviews.llvm.org/D149757
More information about the llvm-commits
mailing list