[PATCH] D158574: [AArch64][ELF] Support PAUTH ABI marking

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

The way D158574 <https://reviews.llvm.org/D158574> and D156882 <https://reviews.llvm.org/D156882> are organized looks awkward to me. I think the preferred way is

- patch A: add constants to BinaryFormat and implement llvm-readobj
- patch B: full-fledged lld implementation



================
Comment at: lld/ELF/SyntheticSections.cpp:375
+
+Aarch64PauthAbiTag::Aarch64PauthAbiTag()
+    : SyntheticSection(llvm::ELF::SHF_ALLOC, llvm::ELF::SHT_NOTE,
----------------
The section name convention is `AArch64*` instead of `Aarch64*`


================
Comment at: lld/ELF/SyntheticSections.cpp:384
+void Aarch64PauthAbiTag::writeTo(uint8_t *buf) {
+  assert(isNeeded());
+  const SmallVector<uint8_t, 0> &data = config->aarch64PauthAbiTag;
----------------
unneeded


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158574/new/

https://reviews.llvm.org/D158574