[PATCH] D159526: [CodeLayout] Refactor some std::vector uses. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 17 14:39:55 PDT 2023


MaskRay created this revision.
MaskRay added reviewers: spupyrev, wenlei, hoy, wlei, rahmanl.
Herald added subscribers: sunshaoce, ayermolo, hiraditya.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

- Remove a redundant copy in ChainT::merge.
- Change {ExtTSPImpl,CDSortImpl}::run to use return value instead of an output parameter
- Rename applyCDSLayout to computeCacheDirectedLayout: (a) avoid rare abbreviation "CDS" (cache-directed sort) (b) "compute" is more conventional for the specific use case
- Change the parameter types from std::vector to ArrayRef so that SmallVector arguments can be used.
- Similarly, rename applyExtTspLayout to computeExtTspLayout.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159526

Files:
  bolt/lib/Passes/ReorderAlgorithm.cpp
  bolt/lib/Passes/ReorderFunctions.cpp
  llvm/include/llvm/Transforms/Utils/CodeLayout.h
  llvm/lib/CodeGen/MachineBlockPlacement.cpp
  llvm/lib/Transforms/Utils/CodeLayout.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159526.556917.patch
Type: text/x-patch
Size: 14476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230917/495ce526/attachment.bin>


More information about the llvm-commits mailing list