[PATCH] D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support

Sun Sep 17 01:56:05 PDT 2023

mpaszkowski added a comment.

In D156049#4641370 <https://reviews.llvm.org/D156049#4641370>, @iliya-diyachkov wrote:

>> Sure, I have made this patch a bit smaller. Still all the fixes are present, but I have kept all the LIT names the same and kept them in the same directories. Renaming, moving, and merging of tests will come in a separate patch.
>
> Thanks! What about removed tests, I'm not sure if we have an analogue of linked-list.ll (with check of OpTypeOpaque). If it's true, is it possible to write such a test?

Hi @iliya-diyachkov! You are right about this one test, I have restored it and rebased the patch. I will work on the linked lists later. When it comes to structs, I have a larger patch with additional tests for which I will create an independent review. Do you think I could continue with this patch in the current form? This will allow us to address next issues in smaller patches.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156049/new/

https://reviews.llvm.org/D156049