[PATCH] D157616: [ExtendLifetimes][2/4] Implement fake.use intrinsic in LLVM to extend the lifetime of operands
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 15 22:48:09 PDT 2023
dblaikie added a comment.
In D157616#4644101 <https://reviews.llvm.org/D157616#4644101>, @jmorse wrote:
> LGTM, with the rider that I'm not sure what the policy is on putting the python test in there. It's fundamentally a debug-info quality test, which is slightly different to the functional tests that we have elsewhere.
Yeah, that doesn't seem suitable - it's an integration test - might as well make it use actual source code and put it in cross-project-tests, I think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157616/new/
https://reviews.llvm.org/D157616
More information about the llvm-commits
mailing list