[llvm] [OpenMPIRBuilder] Added `createTeams` (PR #65785)

Kiran Chandramohan via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 10:47:52 PDT 2023


kiranchandramohan wrote:

Copying the comments about temporary instructions below.

```
StaleCI->eraseFromParent();
-- 
Meinersbur: Please avoid temporary instructions. Use splitBB instead.
shraiysh: AFAIK, splitBB requires an instruction pointer. I have updated this to erase the temporary instruction immediately after I have split the basic blocks, but I cannot figure out a way to completely eliminate temporary instructions. Is this okay?
Meinersbur:
                BasicBlock *TaskExitBB = splitBB(Builder, "task.exit");
                BasicBlock *TaskBodyBB = splitBB(Builder, "task.body");
                BasicBlock *TaskAllocaBB = splitBB(Builder, "task.alloca");
 Note that the reverse order. After this, Builder will insert instructions before the terminator of Currbb (where you probably don't want to insert instructions here).
```



https://github.com/llvm/llvm-project/pull/65785


More information about the llvm-commits mailing list