[PATCH] D157458: [X86] Run X86FastPreTileConfigPass only with FastISel.

Evgenii Kudriashov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 10:18:05 PDT 2023


e-kud added a comment.

In D157458#4646407 <https://reviews.llvm.org/D157458#4646407>, @arsenm wrote:

> Post-selection code should not be tolerant of registers without a class. It is unequivocally a bug for a used register to pass selection without a class dead or not

I've created an issue https://github.com/llvm/llvm-project/issues/66531. However it is not used, that's why it is deleted, but yes, it is still present.

In D157458#4646411 <https://reviews.llvm.org/D157458#4646411>, @arsenm wrote:

> In D157458#4646407 <https://reviews.llvm.org/D157458#4646407>, @arsenm wrote:
>
>> Post-selection code should not be tolerant of registers without a class. It is unequivocally a bug for a used register to pass selection without a class dead or not
>
> The comment changes in MRI seem unrelated to the actual change, can you post those separately?

Now when we consider it as a bug, do we still need a comment? Or put it until fix appears?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157458/new/

https://reviews.llvm.org/D157458



More information about the llvm-commits mailing list