[PATCH] D154205: [MachineLICM] Handle subloops

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:801
+        // pressure because we have already visited inner loop's preheader.
         UpdateRegPressure(&MI);
+      }
----------------
jaykang10 wrote:
> bkramer wrote:
> > When MI is hoisted the pointer is no longer valid. I'm seeing use after frees with asan after this change, so reverted in 3454cf6
> Ah, I am so sorry... Let me check it again.
> Thanks for reverting the commit.
It seems I need to check the MI is erased because CSE can be erased.
@bkramer If possible, can you let me know how I can reproduce the case you saw with asan please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154205/new/

https://reviews.llvm.org/D154205