[llvm] [lit] Echo full RUN lines in case of external shells (PR #66408)

Joel E. Denny via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 07:27:58 PDT 2023


jdenny-ornl wrote:

> > > LGTM.
> > 
> > 
> > Thanks for the quick review!
> > > Note: I've only looked at third commit as instructed, that is: [a398f3e](https://github.com/llvm/llvm-project/commit/a398f3e1dfbfc83489e4d85fd74e8b3f12d469e9)
> > 
> > 
> > You mean [d71c72c](https://github.com/llvm/llvm-project/commit/d71c72c9f20ed34dc2fe2d0ec849a6e44dbf9d20), right? [a398f3e](https://github.com/llvm/llvm-project/commit/a398f3e1dfbfc83489e4d85fd74e8b3f12d469e9) is the first commit.
> 
> Sadly not. I never remember if top is older or newer. Sorry, I'll review it now then. Please ignore my approval for now.

Sorry for the confusion, and thanks again for your help!  My takeaway is that, for situations like this, I should link to the actual commits to avoid the ambiguity.

https://github.com/llvm/llvm-project/pull/66408


More information about the llvm-commits mailing list