[PATCH] D157458: [X86] Run X86FastPreTileConfigPass only with FastISel.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 01:44:52 PDT 2023


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

> Do you think we still need to modify X86FastPreTileConfig?

My suggestion would be to use `getRegClassOrNull` and assert that RC is not nullptr and add a message in the assert that if that assert fails that means we're not running with FastISel and that RC should actually be checked.
Just to be on the safe side of not rediscovery this issue if that pass ends up being run with GISel.



================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:678
+  ///    instruction selection process, or
+  /// 3. The virtual register is dead and a register class has not been asigned
+  ///    during instruction selection
----------------
Typo: asigned => assigned


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157458/new/

https://reviews.llvm.org/D157458



More information about the llvm-commits mailing list