[PATCH] D149288: [X86] Introduce a large data threshold for the medium code model

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:167
+      "large-data-threshold",
+      cl::desc("Choose large data threshold for x86_64 medium code model"),
+      cl::init(0));
----------------
MaskRay wrote:
> Perhaps we should say x86-64 medium/large code model.
> My https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630207.html is still pending after many pings, but I think we can go ahead as the obvious choice.
we can change this to also say "large" once LLVM actually respects it in the large code model


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149288/new/

https://reviews.llvm.org/D149288