[PATCH] D159089: [BOLT][RISCV] Add support for linker relaxation

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 12:16:30 PDT 2023


jobnoorman added a comment.

In D159089#4646164 <https://reviews.llvm.org/D159089#4646164>, @maksfb wrote:

> Thanks for the patch, Job! Do you know what's the effect of changing the `reassignSectionAddress()` invocation on other platforms? Everything else LGTM.

It shouldn't have any effect on other platforms. The change will call `reassignSectionAddress()` a bit earlier in the JITLink pipeline (`notifyResolved` is called right after running the `PostAllocationPasses`, see this <https://llvm.org/docs/JITLink.html#id14>) but this shouldn't matter from BOLT's perspective.

Just to be sure, I'll run `llvm-bolt-wrapper` in the morning to verify (I'm pretty sure I already did this but it has been a while).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159089/new/

https://reviews.llvm.org/D159089



More information about the llvm-commits mailing list