[PATCH] D156954: [lit] Improve test output from lit's internal shell

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 556793.
jdenny added a comment.

Rebased onto the most recent version of D154984 <https://reviews.llvm.org/D154984>.

Due to the changes from the current patch, updated expected results in a few lit tests brought in by the above rebase.

Adjusted lit's `-v` docs not to talk about no-op commands like `:` because this patch changes lit's internal shell not to use that.  PR #65267 <https://github.com/llvm/llvm-project/pull/65267> proposes to change support for external sh-like shells similarly.

Folded in all fixup commits that I landed when trying to land this patch the first time.  They were all tweaks in lit's test suite for portability to windows:

- f254bbf23374190c88a2b1a5f163622fbec9a936 <https://reviews.llvm.org/rGf254bbf23374190c88a2b1a5f163622fbec9a936>
- 3db5db92d746bad8ba1762ca290a176e25d48565 <https://reviews.llvm.org/rG3db5db92d746bad8ba1762ca290a176e25d48565>
- 012d844fb856a89368aca95ca994726554b90f22 <https://reviews.llvm.org/rG012d844fb856a89368aca95ca994726554b90f22>
- b6bd9d275f783f8150c8a04145ef2a31edb4fddf <https://reviews.llvm.org/rGb6bd9d275f783f8150c8a04145ef2a31edb4fddf>

Applied python formatting suggestions from darker.

I don't think this patch requires another review before I land it, but of course reviewers are welcome to comment.  I will wait to re-land it along with PR #65267 <https://github.com/llvm/llvm-project/pull/65267>, which still requires more work and review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156954/new/

https://reviews.llvm.org/D156954

Files:
  libcxx/utils/libcxx/test/dsl.py
  libcxx/utils/libcxx/test/format.py
  llvm/docs/CommandGuide/lit.rst
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/tests/Inputs/lit-opts/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-define/examples/param-subst.txt
  llvm/utils/lit/tests/Inputs/shtest-define/expansion-order.txt
  llvm/utils/lit/tests/Inputs/shtest-define/line-number-substitutions.txt
  llvm/utils/lit/tests/Inputs/shtest-define/name-chars.txt
  llvm/utils/lit/tests/Inputs/shtest-define/recursiveExpansionLimit.txt
  llvm/utils/lit/tests/Inputs/shtest-define/value-equals.txt
  llvm/utils/lit/tests/Inputs/shtest-define/value-escaped.txt
  llvm/utils/lit/tests/Inputs/shtest-define/ws-and-continuations.txt
  llvm/utils/lit/tests/Inputs/shtest-if-else/test.txt
  llvm/utils/lit/tests/Inputs/shtest-output-printing/basic.txt
  llvm/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-output-printing/write-a-lot.py
  llvm/utils/lit/tests/Inputs/shtest-shell/echo-at-redirect-stderr.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/echo-at-redirect-stdin.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/echo-redirect-stderr.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/echo-redirect-stdin.txt
  llvm/utils/lit/tests/allow-retries.py
  llvm/utils/lit/tests/lit-opts.py
  llvm/utils/lit/tests/shtest-define.py
  llvm/utils/lit/tests/shtest-env.py
  llvm/utils/lit/tests/shtest-format.py
  llvm/utils/lit/tests/shtest-if-else.py
  llvm/utils/lit/tests/shtest-inject.py
  llvm/utils/lit/tests/shtest-not.py
  llvm/utils/lit/tests/shtest-output-printing.py
  llvm/utils/lit/tests/shtest-pushd-popd.py
  llvm/utils/lit/tests/shtest-recursive-substitution.py
  llvm/utils/lit/tests/shtest-run-at-line.py
  llvm/utils/lit/tests/shtest-shell.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156954.556793.patch
Type: text/x-patch
Size: 104788 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230914/2e69798e/attachment-0001.bin>