[llvm] [IRSymtab] Replace linear time lookup with DenseSet (PR #66376)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 07:56:14 PDT 2023


================
@@ -270,7 +275,9 @@ Error Builder::addSymbol(const ModuleSymbolTable &Msymtab,
 
   setStr(Sym.IRName, GV->getName());
 
-  bool IsPreservedSymbol = llvm::is_contained(PreservedSymbols, GV->getName());
+  static const DenseSet<StringRef> PreservedSymbolsSet =
+      buildPreservedSymbolsSet();
+  bool IsPreservedSymbol = PreservedSymbolsSet.count(GV->getName());
----------------
nikic wrote:

```suggestion
  bool IsPreservedSymbol = PreservedSymbolsSet.contains(GV->getName());
```

https://github.com/llvm/llvm-project/pull/66376


More information about the llvm-commits mailing list