[llvm] [lit] Fix some issues from --per-test-coverage (PR #65242)

Joel E. Denny via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 07:17:45 PDT 2023


================
@@ -1837,13 +1830,7 @@ def _handleCommand(cls, line_number, line, output, keyword):
         if not output or not output[-1].add_continuation(line_number, keyword, line):
             if output is None:
                 output = []
-            pdbg = "%dbg({keyword} at line {line_number})".format(
-                keyword=keyword, line_number=line_number
-            )
-            assert re.match(
-                kPdbgRegex + "$", pdbg
----------------
jdenny-ornl wrote:

Thanks for the review!

Yes, I performed most steps from the git command line: squash commits and commit logs together, rebase onto the latest main, and force push to the PR.  I then clicked "Squash and merge" and copied and pasted my new commit log there.  The commit log it initially offered was the original comment I posted for this PR, but the focus of the PR has shifted since then.  It would be nicer if it offered the current commit logs, squashed in the same way a `git merge --squash` would squash them.

I don't know how to accomplish the rebase onto main via the github web UI... even though it seems like that's almost always going to be required given how frequently new commits show up on main.  That means I needed to work from the command line anyway, so it seemed more practical to handle squashing there too.

Please let me know if I've overlooked best practices for using the github web UI.

https://github.com/llvm/llvm-project/pull/65242


More information about the llvm-commits mailing list